Skip to content

Conversation

@lemire
Copy link
Member

@lemire lemire commented Mar 24, 2023

We may want to turn FASTFLOAT_CONSTEXPR_TESTS ON by default when C++20 is detected.

@lemire lemire mentioned this pull request Mar 24, 2023
@lemire
Copy link
Member Author

lemire commented Mar 25, 2023

@leni536 Thoughts on the failing tests ?

@leni536
Copy link
Contributor

leni536 commented Mar 26, 2023

https://github.com/fastfloat/fast_float/actions/runs/4521288444/jobs/7962950990#step:3:33

Looks like gcc 9.4.0 doesn't have the three C++20 features that we are testing for, even though it allows building in C++20 mode (possibly with -std=c++2a flag in that version, CMake happily sets that).

So I wouldn't enable constexpr testing in that workflow.

Further errors are less relevant, but they show that several other C++20 constexpr features are missing from that compiler, like allowing uninitialized variables.

@lemire
Copy link
Member Author

lemire commented Mar 26, 2023

@leni536 Fantastic. I had not realized at once that it was GCC 9. Fixing.

@lemire lemire merged commit ab6c987 into main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants