float_common.h: fix possible misuse of comma operator #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@leni536 Would you review? It is a reversion of a change you made, I think. |
leni536
reviewed
Jun 12, 2023
include/fast_float/float_common.h
Outdated
| }; | ||
|
|
||
| /* Helper C++11 constexpr generic implementation of leading_zeroes */ | ||
| fastfloat_really_inline constexpr |
Contributor
There was a problem hiding this comment.
constexpr needs to be changed to FASTFLOAT_CONSTEXPR14 here.
The comma abuse was to make this function constexpr from C++11 (it requires constexpr function bodies to only consist of a single return statement). I think it's OK to revert this, I don't have high ambitions to port constexpr functionality all the way back to C++11.
leni536
suggested changes
Jun 12, 2023
Contributor
leni536
left a comment
leni536
left a comment
There was a problem hiding this comment.
Change constexpr to FASTFLOAT_CONSTEXPR14 on the affected function.
Member
Contributor
Author
|
@lemire done :) |
leni536
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 15 is showing warnings when including fast_float. See screenshot.
That warning says that the comma is meant to return a value, but that value is unused, so that code style is discouraged. I've reverted the code style to the previous one (partial revert of #180), and replaced the remaining commas with semicolons.