fix: BuildCompilerFromPool function overloading type errors#159
Merged
Eomm merged 1 commit intofastify:mainfrom Oct 18, 2025
Merged
fix: BuildCompilerFromPool function overloading type errors#159Eomm merged 1 commit intofastify:mainfrom
Eomm merged 1 commit intofastify:mainfrom
Conversation
4822a8e to
1e9de5b
Compare
Eomm
approved these changes
Oct 18, 2025
Member
Eomm
left a comment
There was a problem hiding this comment.
It makes sense - but it was making sense before too 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here i am once again!
The function overload definition edit suggested in #156 brought additional type errors in fastify because of how ts handles signatures overload.
What i did:
It works, but what did it cost?
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct