Merged
Conversation
Member
|
I don't see any issue with this. |
Member
|
@Eomm Any performance comparison would be helpful |
71 tasks
mcollina
requested changes
Oct 18, 2022
Member
mcollina
left a comment
There was a problem hiding this comment.
I would call the option jtdSerializer:
Member
Author
|
Must add small benchmarks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this draft to get feedback.
Right now this feature works, it needs more testing (CI fails due to the coverage).
The notable code is on the
indexandserializer-compilerfiles, thevalidatoris just a copy-pasteAJV-JTD can be used to serialize the JSON payloads: https://ajv.js.org/guide/getting-started.html#parsing-and-serializing-json
I'm not sure if it is good to include this feature in this package, or we should create a new package that:
fast-json-stringifyby defaultajv-JTDfeatureWhat do you think?
Closes fastify/fastify#3441