Skip to content

nodenext compatibility#90

Merged
Uzlopak merged 5 commits intomainfrom
nodenext
Dec 8, 2022
Merged

nodenext compatibility#90
Uzlopak merged 5 commits intomainfrom
nodenext

Conversation

@Uzlopak
Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak commented Dec 3, 2022

Part of Migration of the infamous triplet to next level, Nodenext support

Checklist

@Uzlopak Uzlopak requested review from Eomm and climba03003 December 3, 2022 23:49
@Uzlopak Uzlopak marked this pull request as draft December 5, 2022 12:13
@Uzlopak
Copy link
Copy Markdown
Contributor Author

Uzlopak commented Dec 5, 2022

Converting to draft to ensure it is working properly

@Uzlopak
Copy link
Copy Markdown
Contributor Author

Uzlopak commented Dec 5, 2022

The typings are wrong. Will rework them

@Uzlopak
Copy link
Copy Markdown
Contributor Author

Uzlopak commented Dec 5, 2022

@Eomm

I will add more typings tests, but I think, this is how the typings should be.

@Uzlopak
Copy link
Copy Markdown
Contributor Author

Uzlopak commented Dec 6, 2022

I worked on this now for soo long,that I am basically confused. I think it is now correct. But like I wrote.... I am confused.

@Uzlopak Uzlopak marked this pull request as ready for review December 6, 2022 00:11
@Eomm Eomm mentioned this pull request Dec 6, 2022
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
@Uzlopak
Copy link
Copy Markdown
Contributor Author

Uzlopak commented Dec 6, 2022

@Eomm PTAL

@Uzlopak Uzlopak requested review from Eomm and climba03003 December 6, 2022 09:51
Copy link
Copy Markdown
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, I would run a Fastify CI with this branch

Do you agree?

@Uzlopak
Copy link
Copy Markdown
Contributor Author

Uzlopak commented Dec 6, 2022

As you wish. But we have no javascript changes, only typings.

I just fixed the typings this morning with my mobile phone and did not work on it since then. I would suggest to add more typings tests, based on the unit tests.

@Eomm
Copy link
Copy Markdown
Member

Eomm commented Dec 7, 2022

As you wish. But we have no javascript changes, only typings.

Yeah, I thought there were more tests with jtd stuff, but it is JS only

@Uzlopak
Copy link
Copy Markdown
Contributor Author

Uzlopak commented Dec 7, 2022

So are the typings correct?

@Eomm
Copy link
Copy Markdown
Member

Eomm commented Dec 8, 2022

@climba03003 PTAL 👍🏽

@Uzlopak Uzlopak merged commit 14b7e46 into main Dec 8, 2022
@Uzlopak Uzlopak deleted the nodenext branch December 8, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants