Conversation
|
Converting to draft to ensure it is working properly |
|
The typings are wrong. Will rework them |
|
I will add more typings tests, but I think, this is how the typings should be. |
|
I worked on this now for soo long,that I am basically confused. I think it is now correct. But like I wrote.... I am confused. |
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
|
@Eomm PTAL |
Eomm
left a comment
There was a problem hiding this comment.
Before merging, I would run a Fastify CI with this branch
Do you agree?
|
As you wish. But we have no javascript changes, only typings. I just fixed the typings this morning with my mobile phone and did not work on it since then. I would suggest to add more typings tests, based on the unit tests. |
Yeah, I thought there were more tests with jtd stuff, but it is JS only |
|
So are the typings correct? |
|
@climba03003 PTAL 👍🏽 |
Part of Migration of the infamous triplet to next level, Nodenext support
Checklist
npm run testandnpm run benchmarkand the Code of conduct