Skip to content

Add check for Buffer #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikaelkaron wants to merge 1 commit into from
Closed

Add check for Buffer #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,15 @@ function deepmergeConstructor (options) {
: Object.keys

function isMergeableObject (value) {
return typeof value === 'object' && value !== null && !(value instanceof RegExp) && !(value instanceof Date)
return typeof value === 'object' && value !== null && !(value instanceof RegExp) && !(value instanceof Date) && !(value instanceof Buffer)
Copy link
Copy Markdown
Member

@Eomm Eomm Nov 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have the same issue with Stream objects

}

function isPrimitive (value) {
return typeof value !== 'object' || value === null
}

function isPrimitiveOrBuiltIn (value) {
return typeof value !== 'object' || value === null || value instanceof RegExp || value instanceof Date
return typeof value !== 'object' || value === null || value instanceof RegExp || value instanceof Date || value instanceof Buffer
}

const mergeArray = options && typeof options.mergeArray === 'function'
Expand Down