fix(auth): avoid mutating opts param in fastifyAuth#270
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the fastifyAuth function was mutating the opts parameter when setting the default relation. The fix ensures that plugin options objects can be safely reused without unexpected side effects.
Key changes:
- Replaced direct mutation of
opts.defaultRelationwith creation of a newpluginOptionsobject - Added test coverage to verify that the original
optsparameter remains unchanged
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| auth.js | Creates new pluginOptions object instead of mutating input opts parameter |
| test/auth.test.js | Adds test to ensure opts parameter is not mutated during plugin registration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
ilteoood
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fastifyAuthfunction was mutating theoptsparameter passed by the caller when setting the default relation. This could cause unexpected side effects for users who reuse the options object.This change creates a new pluginOptions object with the resolved
defaultRelationproperty instead of modifying the original input.Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct