style(ci): use standardized template#29
Merged
mcollina merged 2 commits intofastify:masterfrom Mar 10, 2021
Fdawgs:ci/workflows
Merged
style(ci): use standardized template#29mcollina merged 2 commits intofastify:masterfrom Fdawgs:ci/workflows
mcollina merged 2 commits intofastify:masterfrom
Fdawgs:ci/workflows
Conversation
mcollina
requested changes
Mar 9, 2021
Member
|
It seems that coveralls is configured by not working. |
mcollina
requested changes
Mar 9, 2021
Member
Author
It looks okay and is using the same config as the main Fastify repo and other Fastify plugin repos. |
mcollina
requested changes
Mar 9, 2021
Member
It's likely related. Enabling coveralls or analog for all repos requires significant work, so better avoid it entirely. |
Member
|
The main Fastify repo is a special/ snowflake case. |
Fdawgs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct