Skip to content

Remove disableHook option from readme#5

Merged
cemremengu merged 1 commit intofastify:masterfrom
cemremengu:patch-1
Jan 7, 2019
Merged

Remove disableHook option from readme#5
cemremengu merged 1 commit intofastify:masterfrom
cemremengu:patch-1

Conversation

@cemremengu
Copy link
Copy Markdown
Contributor

@cemremengu cemremengu commented Jan 7, 2019

Closes #4

@mcollina mcollina requested a review from jsumners January 7, 2019 09:04
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait for @jsumners

Copy link
Copy Markdown
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's a leftover of an old implementation.

@cemremengu
Copy link
Copy Markdown
Contributor Author

@mcollina need permission to land this once ready

@mcollina
Copy link
Copy Markdown
Member

mcollina commented Jan 7, 2019

Added you.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cemremengu cemremengu merged commit 70dbf65 into fastify:master Jan 7, 2019
@cemremengu cemremengu deleted the patch-1 branch January 7, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants