fix: resolve premature close error logging (issue #382)#386
Merged
Conversation
…lose logging - Replace pump with stream.pipeline for stream piping - Replace pumpify with stream.compose for stream composition - Remove pump and pumpify dependencies - Fix issue #382: suppress premature close error logging on client disconnect - Add regression tests for client disconnect scenarios The premature close error is expected when clients disconnect mid-response and should not be logged at error level since Fastify handles this gracefully. Refs: #382
mcollina
requested review from
Eomm,
climba03003 and
gurgunday
and removed request for
climba03003
climba03003
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #382 - Removes spurious "premature close" error logging when clients disconnect during compressed streaming responses.
Changes
Fixed premature close error logging (issue @fastify/compress: "premature close" errors in the onSend hook path #382)
onEndcallback now filters out "premature close" errorsReplaced pump/pumpify with native Node.js stream APIs
pump→stream.pipeline(built-in since Node.js 15)pumpify→stream.compose(built-in since Node.js 18)pumpandpumpifyfrom dependenciesTesting
test/regression/issue-382.test.js:reply.compress()path client disconnectsImpact
pumpandpumpify(replaced by native APIs)