Skip to content

fix: retry-after should be in seconds when specified timeWindow#307

Merged
Uzlopak merged 2 commits intomasterfrom
fix-301
Jul 12, 2023
Merged

fix: retry-after should be in seconds when specified timeWindow#307
Uzlopak merged 2 commits intomasterfrom
fix-301

Conversation

@Uzlopak
Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak commented Jul 11, 2023

Fixes #301

Checklist

@Uzlopak Uzlopak requested a review from climba03003 July 11, 2023 18:23
Comment thread index.js Outdated
@Uzlopak Uzlopak requested review from jsumners and mcollina July 11, 2023 21:34
@Uzlopak Uzlopak merged commit a1295dd into master Jul 12, 2023
@Uzlopak Uzlopak deleted the fix-301 branch July 12, 2023 04:51
gurgunday pushed a commit that referenced this pull request Nov 9, 2023
gurgunday added a commit that referenced this pull request Dec 13, 2023
* Update README.md to reflect #307 (#342)

* Redis should work with ban (#336)

* Redis should work with ban

* fix ttl

* simplify

* format

* remove warning

* move property

* add test

* fix test

* fix test

* fix test

* still fix the same test

* make it non-breaking

* make it non-breaking

* make it non-breaking

* make it non-breaking

* perf: add ban back

* Bumped v8.1.0

Signed-off-by: Matteo Collina <hello@matteocollina.com>

* Bumped v9.0.0

Signed-off-by: Matteo Collina <hello@matteocollina.com>

* Fix in-memory cache bug when there is only one entry (#345)

* Bumped v9.0.1

---------

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Trevor Lund <89029310+tlund101@users.noreply.github.com>
Co-authored-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Igor Savin <iselwin@gmail.com>
jsumners added a commit that referenced this pull request Jul 10, 2024
* Updating for v5 (#338)

* ci: add node 21 to test matrix and remove node 14 and 16

* package.json update for v5

* merge main to next (#348)

* Update README.md to reflect #307 (#342)

* Redis should work with ban (#336)

* Redis should work with ban

* fix ttl

* simplify

* format

* remove warning

* move property

* add test

* fix test

* fix test

* fix test

* still fix the same test

* make it non-breaking

* make it non-breaking

* make it non-breaking

* make it non-breaking

* perf: add ban back

* Bumped v8.1.0

Signed-off-by: Matteo Collina <hello@matteocollina.com>

* Bumped v9.0.0

Signed-off-by: Matteo Collina <hello@matteocollina.com>

* Fix in-memory cache bug when there is only one entry (#345)

* Bumped v9.0.1

---------

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Trevor Lund <89029310+tlund101@users.noreply.github.com>
Co-authored-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Igor Savin <iselwin@gmail.com>

* Revert "merge main to next (#348)"

This reverts commit 5446122.

* revert workflow update as its causing issues (#350)

* revert: handle ban in store (#347)

* remove ban handling from store

* don't use negation

* add undef

* don't pass ban to promis

* fix accidental explicit checks

* fix accidental line change

* inline ban

* Workflow v4 (#354)

* refactor: make RedisStore default key a default parameter (#356)

* refactor redis parameters and throw if no instance was provided

* revert error

* Add function support for timeWindow (#357)

* feat: dynamic time window support

* fix: proper usage of timeWindowString

---------

Co-authored-by: lukas <git@lukaselsner.de>

* update docs (#360)

* fix: remove unnecessary parameter timeWindow (#363)

* refactor: consistent option handling (#365)

* small refactor in option handling

* simplify

* simplify

* perf: pregenerate `timeWindow` string when possible and use `noop` as default function (#364)

* pregenerate timeWindowString if possible

* simplify

* simplify

* noop

* simplify

* simple-example

* rename

* update for v5 (#370)

* update for v5

* update for v5

* update for v5

* update for v5

* update for v5

* update for v5

* update for v5

* update for v5

* update for v5

* update for v5

* update for v5

* update for v5

* update for v5

* update for v5

* update fastify deps

---------

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Eliphaz Bouye <53824344+Eliphaz-Bouye@users.noreply.github.com>
Co-authored-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com>
Co-authored-by: Trevor Lund <89029310+tlund101@users.noreply.github.com>
Co-authored-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Igor Savin <iselwin@gmail.com>
Co-authored-by: lukas <mindrunner@users.noreply.github.com>
Co-authored-by: lukas <git@lukaselsner.de>
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Retry-After header value

2 participants