Skip to content

fix: return type of rateLimit#375

Merged
mcollina merged 1 commit intofastify:masterfrom
MunifTanjim:fix-type
Sep 2, 2024
Merged

fix: return type of rateLimit#375
mcollina merged 1 commit intofastify:masterfrom
MunifTanjim:fix-type

Conversation

@MunifTanjim
Copy link
Copy Markdown
Contributor

@MunifTanjim MunifTanjim commented Jul 31, 2024

Checklist

@MunifTanjim MunifTanjim marked this pull request as ready for review July 31, 2024 12:31
@MunifTanjim
Copy link
Copy Markdown
Contributor Author

@jsumners @Uzlopak Can I get a review on this one? Without these changes we get TypeScript error when trying to use this package.

@jsumners
Copy link
Copy Markdown
Member

jsumners commented Aug 4, 2024

I cannot read TypeScript. Please do not tag me on any TypeScript changes.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit f7b4f7e into fastify:master Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants