Merged
Conversation
2 tasks
Uzlopak
previously requested changes
Nov 4, 2024
Contributor
Uzlopak
left a comment
Uzlopak
left a comment
There was a problem hiding this comment.
I dont like it somehow. Blocking it so that i can think about it in a free minute.
gurgunday
reviewed
Nov 4, 2024
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> Signed-off-by: Aniket Sinha <aniketsinha1304@gmail.com>
gurgunday
reviewed
Nov 4, 2024
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> Signed-off-by: Aniket Sinha <aniketsinha1304@gmail.com>
gurgunday
reviewed
Nov 4, 2024
Member
gurgunday
left a comment
gurgunday
left a comment
There was a problem hiding this comment.
LGTM other than a final nit
Contributor
Author
|
Hi @gurgunday , @Uzlopak I have updated the lua script to make the ttl resetting consistent incase of continueExceeding and exponentialBackoff |
Contributor
Author
|
@Uzlopak Can you suggest a better approach for this? |
Contributor
|
Will review it today :) |
Fdawgs
requested changes
Nov 12, 2024
Co-authored-by: Frazer Smith <frazer.dev@icloud.com> Signed-off-by: Aniket Sinha <aniketsinha1304@gmail.com>
Contributor
Author
|
@Uzlopak @climba03003 @Fdawgs Guys, can you please review? |
gurgunday
reviewed
Nov 15, 2024
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> Signed-off-by: Aniket Sinha <aniketsinha1304@gmail.com>
Contributor
Author
|
Done @gurgunday |
gurgunday
requested changes
Nov 15, 2024
gurgunday
approved these changes
Nov 15, 2024
Member
|
Thanks for the PR and taking the time to address the feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to add exponential backoff.
#279
Checklist
npm run testandnpm run benchmarkand the Code of conduct