fix: after should show the same ttl as the rate limit headers#394
Merged
fix: after should show the same ttl as the rate limit headers#394
after should show the same ttl as the rate limit headers#394Conversation
Member
Author
|
I will rebase after #393 merges |
gurgunday
force-pushed
the
fix-timewindow
branch
from
b9ec73e to
592694f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the rate limiter by only looking at the
ttlto construct theaftermessage — this aligns the message with theRetry-Afterheader; before, it would just send thetimeWindow, which is inaccurateSo even if a user had 5 seconds left, if the
timeWindowwas 50 seconds, the error would say,"Retry in 50 seconds"and not"Retry in 5 seconds"