Skip to content

docs: update references to old fastify-* modules#111

Merged
mcollina merged 1 commit into
masterfrom
docs/org-name
Apr 29, 2022
Merged

docs: update references to old fastify-* modules#111
mcollina merged 1 commit into
masterfrom
docs/org-name

Conversation

@Fdawgs
Copy link
Copy Markdown
Member

@Fdawgs Fdawgs commented Apr 29, 2022

See fastify/fastify#3733

Checklist

Comment thread README.md
import {requestContext} from '@fastify/request-context'

declare module 'fastify-request-context' {
declare module '@fastify/request-context' {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know enough about TS to know if this is okay?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's ok

Comment thread README.md
import {requestContext} from '@fastify/request-context'

declare module 'fastify-request-context' {
declare module '@fastify/request-context' {
Copy link
Copy Markdown
Member Author

@Fdawgs Fdawgs Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know enough about TS to know if this is okay also?

@Fdawgs Fdawgs requested a review from a team April 29, 2022 13:06
Copy link
Copy Markdown
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RafaelGSS
Copy link
Copy Markdown
Member

just double check @fastify/typescript

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 9f58363 into master Apr 29, 2022
@Fdawgs Fdawgs deleted the docs/org-name branch April 29, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants