Skip to content

feat: added AsyncResource factory function option#173

Merged
mcollina merged 1 commit intofastify:masterfrom
imjuni:master
Jan 6, 2024
Merged

feat: added AsyncResource factory function option#173
mcollina merged 1 commit intofastify:masterfrom
imjuni:master

Conversation

@imjuni
Copy link
Contributor

@imjuni imjuni commented Dec 13, 2023

Checklist

@Eomm
Copy link
Member

Eomm commented Dec 18, 2023

Could you update the PR?
The CI should be green now

@Eomm Eomm linked an issue Dec 18, 2023 that may be closed by this pull request
2 tasks
@imjuni imjuni closed this Dec 19, 2023
@imjuni imjuni reopened this Dec 19, 2023
@imjuni
Copy link
Contributor Author

imjuni commented Dec 19, 2023

Updated

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@imjuni
Copy link
Contributor Author

imjuni commented Jan 5, 2024

Is there anything else I should do?

@mcollina mcollina merged commit 5122a18 into fastify:master Jan 6, 2024
@mcollina
Copy link
Member

mcollina commented Jan 6, 2024

Nope, it's in our queue for shipping a releass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customizable AsyncResource.type and create-resource

3 participants