fix: preserve query string when stripping prefix from req.url#251
Closed
fix: preserve query string when stripping prefix from req.url#251
Conversation
normalizePathForMatching() was applied to the full URL including the query string, but FindMyWay.sanitizeUrlPath() strips query parameters as part of path sanitization. Now the query string is extracted before normalization and re-appended afterward. Closes #248 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.use('/prefix', fn)strips the query string fromreq.urlbefore it reaches the middlewarenormalizePathForMatching()being applied to the full URL including the query string —FindMyWay.sanitizeUrlPath()strips query parameters as part of path sanitizationCloses #248
Test plan
req.url stripping preserves query stringcovering multiple query strings, single query param, and no query param🤖 Generated with Claude Code