Fix: add ability to create Partitioned Cookies#226
Merged
mcollina merged 7 commits intofastify:masterfrom Dec 8, 2023
Merged
Conversation
2 tasks
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
gurgunday
reviewed
Dec 4, 2023
Co-authored-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com>
Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
Contributor
Author
|
@Eomm , Tests added |
Uzlopak
reviewed
Dec 5, 2023
Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
Contributor
Author
|
@Uzlopak Thanks ! |
Fdawgs
requested changes
Dec 5, 2023
Member
Fdawgs
left a comment
Fdawgs
left a comment
There was a problem hiding this comment.
The PR title needs to be rewritten as it's not great in its current state. Won't make much sense to users reading release notes.
Member
|
What is wrong with this CI? Rerunning |
gurgunday
approved these changes
Dec 5, 2023
Contributor
|
PTAL |
Member
|
It's not enabled by default? Also, I wonder why we're not using fastify/cookie's cookie module here |
Member
|
And we might want to label it as experimental or non-standard |
gurgunday
reviewed
Dec 6, 2023
Co-authored-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com>
Member
|
I am completely against making a draft proposal the default implementation of anything. |
Member
|
Yeah me too, the title is wrong, the PR just adds |
Uzlopak
changed the title
Contributor
|
Is the title now better? |
Fdawgs
approved these changes
Dec 8, 2023
Contributor
Author
|
Thank you everyone ! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #213
run
npm run testandnpm run benchmarknpm run benchmark -> failed
TypeError: redisStoreFactory is not a function
at createServer (C:\GitHub\fastify-session\benchmark\bench.js:19:24)
at testFunction (C:\GitHub\fastify-session\benchmark\bench.js:56:18)
at main (C:\GitHub\fastify-session\benchmark\bench.js:83:15)
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct