Fix type argument inference of session.get(key) and session.set(key, value)#249
Merged
mcollina merged 2 commits intofastify:masterfrom May 7, 2024
zetaraku:patch-1
Merged
Fix type argument inference of session.get(key) and session.set(key, value)#249mcollina merged 2 commits intofastify:masterfrom zetaraku:patch-1
session.get(key) and session.set(key, value)#249mcollina merged 2 commits intofastify:masterfrom
zetaraku:patch-1
Conversation
Signed-off-by: Raku Zeta <zetaraku@gmail.com>
Signed-off-by: Raku Zeta <zetaraku@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current generic method
session.get(key)accidentally allows the return value to be inferred into any type.The
session.set(key, value)also allowsvalueof any type to be passed in.Note: This fix removes the second generic param
V, so it will break an undocumented usage for TypeScript users specifying both two generic type parameters. (This should be rare.)Checklist
npm run testandnpm run benchmarkand the Code of conduct