Merged
Conversation
The `get_and_resolve` method is only needed when `use-config-json` feature is not used.
This fixes at least the case where you try to import `design-system.fifthtry.site` inside of a `ds.ftd` file which is given to the provided-via of design-system package imported as a dependency in your package.
Calling `serde_json::to_string` on a `serde_json::Value::String` produces a quoted string which is a valid json value but not what we want to put inside url query params. To handle this, we check if the value is a String and use the inner string value if it is. In all other situations we want a safely escaped json value that we can decode on the other side (ft_sdk).
amitu
previously approved these changes
Jun 16, 2025
amitu
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came across a few issues when trying to get https://www.fifthtry.com/ide/folio-frame/ package to work (anyone can download the source of this package from https://www.fifthtry.com/folio-frame.zip).
Especially the case where you try to import
design-system.fifthtry.siteinds.ftd. This previously working during my testing is probably because of the state ofRequestConfig::module_package_map. Basically, during the import resolution process, it tries every dependency for a module until it finds the right one. This process leaves themodule_package_mapwithPackageforinherited-caller_module that is not the main package. We catch this early and if the caller_module starts withinherited-then we use the main package name instead (similar to what we did for resolution of an import target).When resolving import for the
provided-viamodule (internally prefixed withinherited-), only the main package is checked now, instead of checking the "current package" (which is determined based on caller module path)Also fixes the http processor to preserve the old behaviour of sending unquoted string values in url query parameter.