Skip to content

Add caching option to list_tab method #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
howprobable wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add caching option to list_tab method #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pychrome/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ def new_tab(self, url=None, timeout=None):
self._tabs[tab.id] = tab
return tab

def list_tab(self, timeout=None):
def list_tab(self, timeout=None, use_cache=False):
if use_cache:
return list(self._tabs.values())

rp = requests.get("%s/json" % self.dev_url, json=True, timeout=timeout)
tabs_map = {}
for tab_json in rp.json():
Expand Down