feat: Support arm docker build#6061
Conversation
75cba67 to
40705fb
Compare
5a041f6 to
645ffc0
Compare
| - "sdk/python/feast/feature_server.py" | ||
| - "infra/scripts/feature_server_docker_smoke.py" | ||
| - "Makefile" | ||
| - ".github/workflows/publish_images.yml" |
There was a problem hiding this comment.
also .github/workflows/docker_smoke_tests.yml
|
@Anarion-zuo This looks good, can we also please get support of arm for dev image ? |
Done |
@Anarion-zuo I don't see master_only workflow modified to build and push dev images with arm arch |
|
It would seem that https://github.com/feast-dev/feast/blob/master/.github/workflows/master_only.yml can only be triggered upon merge or push into the master branch. I made changes in the |
.github/workflows/master_only.yml
Outdated
| - name: Build image | ||
| run: | | ||
| make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA} | ||
| if [[ "${{ matrix.component }}" == "feature-server-dev" ]]; then |
There was a problem hiding this comment.
I think we should keep using make target, this avoids little maintenance for future
- name: Build image
run: |
if [[ "${{ matrix.component }}" == "feature-server-dev" ]]; then
make build-feature-server-dev-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA} DOCKER_PUSH=true DOCKER_PLATFORMS=linux/amd64,linux/arm64
else
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
fi
- name: Push image
run: |
if [[ "${{ matrix.component }}" == "feature-server-dev" ]]; then
docker buildx imagetools create -t ${REGISTRY}/feature-server:develop ${REGISTRY}/feature-server:${GITHUB_SHA}
else
docker tag ${REGISTRY}/${{ matrix.component }}:${GITHUB_SHA} ${REGISTRY}/${{ matrix.component }}:develop
docker push ${REGISTRY}/${{ matrix.component }} --all-tags
fi
There was a problem hiding this comment.
I modified the 'Build image' part to make one-liners.
5724fab to
22f840e
Compare
Signed-off-by: aaronzuo <anarionzuo@outlook.com>
Signed-off-by: aaronzuo <anarionzuo@outlook.com>
Signed-off-by: aaronzuo <anarionzuo@outlook.com>
Signed-off-by: aaronzuo <anarionzuo@outlook.com>
Signed-off-by: aaronzuo <anarionzuo@outlook.com>
Signed-off-by: aaronzuo <anarionzuo@outlook.com>
1dcc097 to
5cba559
Compare
What this PR does / why we need it:
Which issue(s) this PR fixes:
#4813
Misc