[DEV-14642] Fix sorting on Award Type and add sorting for loans#4637
Open
AHasan-FRB wants to merge 9 commits intoqatfrom
Open
[DEV-14642] Fix sorting on Award Type and add sorting for loans#4637AHasan-FRB wants to merge 9 commits intoqatfrom
AHasan-FRB wants to merge 9 commits intoqatfrom
Conversation
… and ensures spark is installed to the environemtn
…d award type field to lookup mapping
zachflanders-frb
requested changes
Apr 30, 2026
Contributor
zachflanders-frb
left a comment
There was a problem hiding this comment.
I'm requesting changes to see if we can add a test case to sort by Award Type/Contract Award Type. There is a test test_spending_by_award_sort_recipient_location that you can probably use as a model.
Left a comment about maybe not needing to check for type_description in the views, but feel free to ignore.
Comment on lines
+476
to
+477
| if sort_by_fields[0] == "type_description": | ||
| sort_by_fields[0] = "type_description.keyword" |
Contributor
There was a problem hiding this comment.
I don't think we need to modify this here since it is updated in the elasticsearch_lookups.
Comment on lines
+205
to
+206
| if sort_by_fields[0] == "type_description": | ||
| sort_by_fields[0] = "type_description.keyword" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Resolved issues with award type not searching correctly due to not using the keyword, rather the text.
Added Awards to sorting.
Technical Details:
type_description.keywordin places award type is referred toRequirements for PR Merge:
Explain N/A in above checklist: