fix(cli): normalize Go repoUrl in dynamic snippet comparison#13272
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
fix(cli): normalize Go repoUrl in dynamic snippet comparison#13272devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: will.kendall@buildwithfern.com <wpk235@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Go SDK snippet uploads always failing with the warning:
Discovered while upgrading SchematicHQ/schematic-fern-config.
Link to Devin Session: https://app.devin.ai/sessions/8c552d64dcab44d5af78c0e897d02ccf
Requested by: @willkendall01
Changes Made
normalizeGoPackageForLookupto the generator'srepoUrlin the"go"case ofgenerateLanguageSpecificDynamicIRs, matching the normalization already applied to the snippet config side (line 952).Root cause: Commit
0e8c3512cba(v3.47.9) addednormalizeGoPackageForLookupto strip thehttps://prefix from the snippet config side, but did not apply the same normalization to the generator'srepoUrl. This caused the comparison at line 1018 to always fail for Go ("github.com/owner/repo"!=="https://github.com/owner/repo"), triggering the "unknown package" warning and skipping Go dynamic snippet generation.Review Checklist
"swift"case (line 986) also readsrepoUrldirectly. Verify whether Swift has the samehttps://mismatch issue or if the snippet config side for Swift doesn't normalize.normalizeGoPackageForLookupis the correct normalization (it is — same function used on line 952 for the other side of the comparison)Testing
normalizeGoPackageForLookupfunction (return repository.replace(/^https:\/\//, "")) is already used on the snippet config side — this change makes the generator side consistent