Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
To address the validation issue created due to the potential variations in String ordering during comparison.
This PR aims to fix 18 tests:
REASON AND FIX:
The issue arises while creating a custom node
createDependencyNodewith the specified order which doesn’t match with the order of elements initialized in the classArtifactData.depgraph-maven-plugin/src/test/java/com/github/ferstl/depgraph/dependency/AbstractDependencyNodeNameRendererTest.java
Line 56 in f93bf3b
Due to this, validating the String with another string doesn’t turn out to return true.
The fix is to use a
@JsonPropertyOrderannotation to specify the order in which the properties of the ArtifactData class should always appear in the order specified.REPRODUCE:
This was found by using the NonDex tool.