-
Notifications
You must be signed in to change notification settings - Fork 18
Fix missing reference url slash #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing reference url slash #26
Conversation
Tweak default config
|
This doesn't solve the issue I had where the URL has a trailing slash and so does the referenceUrl, resulting in two slashes at the end of the domain. Right? I think it was a mistake on my part to hack around this with a regex. I'd rather fix the url we're placing in the |
|
@danreeves makes sense to me. I think we will have to be careful as This means |
|
If we do at the point where we have the full url, before https://github.com/fffunction/backstop-crawl/blob/master/lib/crawl.js#L116 it should be fine. |
|
@danreeves should be all set now. Thanks for talking through this with me! |
Addresses #25 by replacing one or more trailing slashes in
referenceUrlwith a single trailing slash.