chore: remove obsolete // +build tag

[zjumathcode]

Related Issues

Proposed Changes

From Go 1.17, the preferred syntax for build constraints is //go:build,
which replaces the old // +build form. The old style is now considered
deprecated but still supported for backward compatibility.

This change removes the obsolete // +build xxx line, keeping only the
modern //go:build xxx directive.

More info: golang/go#41184 and https://go.dev/doc/go1.17#build-lines

Design Doc / Proposal：
https://go.dev/design/draft-gobuild

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

• Commits have a clear commit message.
• PR title conforms with contribution conventions
• Update CHANGELOG.md or signal that this change does not need it per contribution conventions
• New features have usage guidelines and / or documentation updates in
  • Lotus Documentation
  • Discussion Tutorials
• Tests exist for new functionality or change in behavior
• CI is green

[github-actions]

Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions

PR title now matches the required format.

[zjumathcode]

Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions

Modified~

[rvagg]

Nice, thanks, but if you wouldn't mind running git grep '// +build' and getting all of them that have go: variants (other than those in extern/filecoin-ffi which come from https://github.com/filecoin-project/filecoin-ffi) then we can avoid the inevitable follow-up PRs.

[zjumathcode]

Nice, thanks, but if you wouldn't mind running git grep '// +build' and getting all of them that have go: variants (other than those in extern/filecoin-ffi which come from https://github.com/filecoin-project/filecoin-ffi) then we can avoid the inevitable follow-up PRs.

@rvagg Thank you for your suggestions. I have reviewed, revised, and resubmitted. I have confirmed that there are no similar examples.

[Copilot]

Pull request overview

This PR modernizes the codebase by removing deprecated // +build build constraint syntax in favor of the modern //go:build directive introduced in Go 1.17. The changes are purely cosmetic cleanup with no functional impact.

Key Changes:

• Removed obsolete // +build tags from 24 files across the codebase
• Retained modern //go:build directives that are semantically equivalent to the removed tags

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
storage/sealer/fsutil/statfs_unix.go	Removed // +build !windows tag
storage/sealer/fsutil/filesize_unix.go	Removed // +build !windows tag
storage/sealer/fsutil/dealloc_other.go	Removed // +build !linux tag
lib/ulimit/ulimit_unix.go	Removed // +build darwin linux netbsd openbsd tag
lib/ulimit/ulimit_test.go	Removed // +build !windows tag
lib/ulimit/ulimit_freebsd.go	Removed // +build freebsd tag
chain/types/message_fuzz.go	Removed // +build gofuzz tag
build/tools.go	Removed // +build tools tag
build/builtin_actors_gen_test.go	Removed // +build release tag
build/buildconstants/params_testground_test.go	Removed // +build testground tag
build/buildconstants/params_testground.go	Removed // +build testground tag
build/buildconstants/params_shared_vals.go	Removed // +build !testground tag
build/buildconstants/params_mainnet_test.go	Removed // +build !debug,!2k,!testground,!calibnet,!butterflynet,!interopnet tag
build/buildconstants/params_mainnet.go	Removed // +build !debug,!2k,!testground,!calibnet,!butterflynet,!interopnet tag
build/buildconstants/params_interop_test.go	Removed // +build interopnet tag
build/buildconstants/params_interop.go	Removed // +build interopnet tag
build/buildconstants/params_debug.go	Removed // +build debug tag
build/buildconstants/params_calibnet_test.go	Removed // +build calibnet tag
build/buildconstants/params_calibnet.go	Removed // +build calibnet tag
build/buildconstants/params_butterfly_test.go	Removed // +build butterflynet tag
build/buildconstants/params_butterfly.go	Removed // +build butterflynet tag
build/buildconstants/params_2k_test.go	Removed // +build debug 2k tag
build/buildconstants/params_2k.go	Removed // +build debug 2k tag

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[rvagg]

By my reckoning these are still missing @zjumathcode:

chain/proofs/ffi/verifier_cgo.go:// +build cgo
cli/lotus/daemon.go:// +build !nodaemon
cli/lotus/daemon_nodaemon.go:// +build nodaemon
cli/lotus/debug_advance.go:// +build debug
storage/sealer/cgroups.go:// +build !linux
storage/sealer/cgroups_linux.go:// +build linux
storage/sealer/ffiwrapper/prover_cgo.go:// +build cgo
storage/sealer/ffiwrapper/sealer_cgo.go:// +build cgo
storage/sealer/ffiwrapper/verifier_cgo.go:// +build cgo

[zjumathcode]

By my reckoning these are still missing @zjumathcode:

chain/proofs/ffi/verifier_cgo.go:// +build cgo
cli/lotus/daemon.go:// +build !nodaemon
cli/lotus/daemon_nodaemon.go:// +build nodaemon
cli/lotus/debug_advance.go:// +build debug
storage/sealer/cgroups.go:// +build !linux
storage/sealer/cgroups_linux.go:// +build linux
storage/sealer/ffiwrapper/prover_cgo.go:// +build cgo
storage/sealer/ffiwrapper/sealer_cgo.go:// +build cgo
storage/sealer/ffiwrapper/verifier_cgo.go:// +build cgo

@rvagg Oh, indeed. I checked and found the reason: it's because the + has a special meaning in regular expressions. I should use ag '// \+build' to search. The git grep '// +build' you provided is also completely correct.

Modified. Thank you very much for your guidance.

[rvagg]

Excellent, thanks