Distribution package only including firebase_admin#263
Merged
hiranya911 merged 2 commits intofirebase:masterfrom Feb 13, 2019
fgmacedo:fgm-fix-remove-integration-from-packages
Merged
Distribution package only including firebase_admin#263hiranya911 merged 2 commits intofirebase:masterfrom fgmacedo:fgm-fix-remove-integration-from-packages
hiranya911 merged 2 commits intofirebase:masterfrom
fgmacedo:fgm-fix-remove-integration-from-packages
Conversation
hiranya911
suggested changes
Feb 12, 2019
fgmacedo
changed the title
…ython into fgm-fix-remove-integration-from-packages
Contributor
Author
|
@hiranya911 thanks for merging! Do you have any plans for a new release coming? We are unable to install the project. Even our fork is not working, because a |
Contributor
|
@fgmacedo will try to get something out next week. |
Contributor
Author
|
Thanks @hiranya911! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firebase-admin is polluting the Python's default package namespace with a integration package.
We already have an internal app using integration namespace, so the names are in conflict.
I think that integration should not be included on the distribution package, since It's related to integration tests only.
This PR changes the pattern for discovering packages to
firebase*.