feat(js/plugins/compat-oai): allow passing api key at runtime instead of config time#3946
Merged
feat(js/plugins/compat-oai): allow passing api key at runtime instead of config time#3946
Conversation
ssbushi
reviewed
Dec 16, 2025
Contributor
ssbushi
left a comment
There was a problem hiding this comment.
What is the point of supporting per-request API keys?
Collaborator
Author
Folks build apps where user provides the API key. The key is dynamically fetched from a DB. |
ssbushi
reviewed
Dec 16, 2025
ssbushi
approved these changes
Dec 16, 2025
Contributor
ssbushi
left a comment
There was a problem hiding this comment.
LGTM, save for 1 small comment.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (if applicable):