Merged
Conversation
Member
|
Sounds like a good idea. I guess we also put the options manager in there, right? |
Contributor
Author
Yeah exactly. Also whatever clever ideas happen with the appctx. |
…nstall-experiment
dham
previously approved these changes
Apr 22, 2025
dham
previously approved these changes
Jun 11, 2025
ksagiyam
approved these changes
Jun 12, 2025
…nstall-experiment
Contributor
Author
|
Merging as only link check is failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of users have been cargo-culting Firedrake's PETSc code for a long time (especially the options manager). This is even happening outside of the Firedrake user base. I (and others) think that it therefore makes some sense to have an external mini package that can store this sort of thing.
I have started this process off by writing petsctools. At the moment it does just the thing I want which is to warn users if their PETSc and petsc4py versions do not match. Also if
PETSC_DIRis set but does not match what petsc4py thinks then an exception is raised.If people are happy I will move petsctools into the firedrakeproject organisation and make a release.