Skip to content

SLATE: support dual space#4342

Merged
connorjward merged 9 commits intoreleasefrom
pbrubeck/dual-slate
Jun 6, 2025
Merged

SLATE: support dual space#4342
connorjward merged 9 commits intoreleasefrom
pbrubeck/dual-slate

Conversation

@pbrubeck
Copy link
Contributor

@pbrubeck pbrubeck commented May 28, 2025

Description

Support dual spaces and Coarguments in SLATE Tensors.

Fixes #4340

@pbrubeck pbrubeck force-pushed the pbrubeck/dual-slate branch 2 times, most recently from fa717f2 to 5b27810 Compare May 30, 2025 09:47
@pbrubeck pbrubeck force-pushed the pbrubeck/dual-slate branch from 5b27810 to d1433b8 Compare May 30, 2025 09:52
connorjward
connorjward previously approved these changes Jun 4, 2025
connorjward
connorjward previously approved these changes Jun 5, 2025
@connorjward connorjward enabled auto-merge (squash) June 5, 2025 16:09
@connorjward connorjward disabled auto-merge June 5, 2025 19:02
@connorjward
Copy link
Contributor

@pbrubeck this is suddenly failing a lot of tests. Any idea why? I just merged in release but the change was trivial so I can't imagine that that was the issue.

@pbrubeck
Copy link
Contributor Author

pbrubeck commented Jun 5, 2025

@pbrubeck this is suddenly failing a lot of tests. Any idea why? I just merged in release but the change was trivial so I can't imagine that that was the issue.

Those were genuine failures, hopefully I have addressed them now. I guess I didn't realise as I was expecting CI to fail due to the broken link.

Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@connorjward connorjward merged commit 6ea9145 into release Jun 6, 2025
6 of 7 checks passed
@connorjward connorjward deleted the pbrubeck/dual-slate branch June 6, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants