Merged
Conversation
connorjward
requested changes
Sep 4, 2025
leo-collins
force-pushed
the
leo/deprecate-at
branch
from
2a778c7 to
be44d6e
Compare
leo-collins
commented
Sep 4, 2025
leo-collins
force-pushed
the
leo/deprecate-at
branch
from
be44d6e to
d121e89
Compare
leo-collins
force-pushed
the
leo/deprecate-at
branch
from
aa8d190 to
7988c39
Compare
leo-collins
force-pushed
the
leo/deprecate-at
branch
from
7988c39 to
83d56ef
Compare
dham
approved these changes
Sep 24, 2025
This was referenced Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
Function.at()method in favour of thePointEvaluatorclass introduced in the PR above. Using.at()now shows a warning telling users to use aPointEvaluator. The docs for.at()are removed. All tests are updated to usePointEvaluatorwhere necessary.The only place we use
.atstill is in thestreamlinefunction; see #4573.This solves issues #3080, #2790, #4478