Explicitly assemble the interpolate adjoint matrix#4576
Merged
Conversation
pbrubeck
force-pushed
the
pbrubeck/interp-adjoint-explicit
branch
6 times, most recently
from
0a4ed77 to
f82b140
Compare
pbrubeck
commented
Sep 21, 2025
pbrubeck
commented
Sep 22, 2025
pbrubeck
commented
Sep 23, 2025
pbrubeck
commented
Sep 23, 2025
pbrubeck
commented
Sep 23, 2025
pbrubeck
commented
Sep 23, 2025
pbrubeck
commented
Sep 23, 2025
connorjward
requested changes
Sep 23, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Please can you provide more detail in the PR descriptions for this and #4552? I don't know why these changes need to be made.
pbrubeck
commented
Sep 23, 2025
connorjward
reviewed
Sep 23, 2025
pbrubeck
force-pushed
the
pbrubeck/interp-adjoint-explicit
branch
2 times, most recently
from
2f4554a to
ea997ea
Compare
pbrubeck
commented
Sep 25, 2025
connorjward
requested changes
Sep 25, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
I think this is really close now. Definitely much much happier with this. You have deleted a lot of complicated code and replaced it with things that I can actually understand!
pbrubeck
commented
Sep 25, 2025
pbrubeck
commented
Sep 25, 2025
dham
reviewed
Sep 26, 2025
pbrubeck
commented
Sep 26, 2025
dham
previously approved these changes
Sep 30, 2025
pbrubeck
force-pushed
the
pbrubeck/interp-adjoint-explicit
branch
from
8d631f8 to
210bae0
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables code generation for all possible argument combinations in
Interpolate:Interpolate(Argument(1), Coargument(0))Interpolate(Argument(0), Coargument(1))Interpolate({Function | Expr}, Coargument(0))Interpolate(Argument(0), Cofunction)Interpolate({Function | Expr}, Cofunction)Previously we indirectly obtained 2 and 4 from the transpose of 1, and 5 via a dot product involving 3.
The big win is that code generation does not deal with these 5 cases as special cases, and we always do matrix-free computations (unless a 2-form is explicitly requested).
Depends on #4552 which mainly addresses 4 and 5.