BUG: Fix FormSum involving the output tensor#4670
Merged
Conversation
pbrubeck
force-pushed
the
pbrubeck/fix/formsum
branch
from
5a45d8b to
48d4d9c
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/formsum
branch
from
2c06a2d to
4c4e330
Compare
pbrubeck
commented
Oct 21, 2025
connorjward
reviewed
Oct 22, 2025
pbrubeck
commented
Oct 22, 2025
pbrubeck
force-pushed
the
pbrubeck/fix/formsum
branch
from
950e9bb to
69bc8ea
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/formsum
branch
from
d3587fa to
032886f
Compare
connorjward
requested changes
Oct 27, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Other than this you can consider this approved.
pbrubeck
commented
Oct 27, 2025
Contributor
Author
|
The G-adopt and linkcheck failures are expected. I'm merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
assemble(c1 * tensor + c2 * other_tensor, tensor=tensor)