Merged
Conversation
VTK releases are sporadic so when macOS eagerly upgrades to a new Python version it breaks our install for some time.
Contributor
Author
|
@JHopeCollins are you happy for us to go ahead and merge this? This is a minor policy/strategy change but I think if we're both happy with it we can just merge it. @leo-collins I'd love to make a new release when this and #4675 are merged. If you can get that over the line soon (i.e. early next week) that would be amazing. |
Member
Yes happy with this. It causes problems on a fairly regular basis and it isn't a hard dependency for running Firedrake so it makes sense not to have it as a hard dependency for installing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I was wrong to make VTK a hard dependency of Firedrake. They may publish wheels for all architectures now but they still make releases sporadically. This has meant that macOS users have had to downgrade their Python to 3.13 during install due to there not yet being a 3.14 wheel.
From a software maitainer perspective having VTK be optional is desirable because it should make it clearer to users that the reason their installation isn't working isn't our fault!
Note that VTK will still be available in the firedrake-vanilla containers.
This should go into the next patch release (and soon at that).