Avoid using Python MPI operation in _parent_mesh_embedding#4926
Open
leo-collins wants to merge 5 commits intomainfrom
Open
Avoid using Python MPI operation in _parent_mesh_embedding#4926leo-collins wants to merge 5 commits intomainfrom
_parent_mesh_embedding#4926leo-collins wants to merge 5 commits intomainfrom
Conversation
Contributor
|
This seems reasonable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building a VOM, the owning cell is determined by the minimum L1 distance to the reference cell. Ties are broken by choosing the cell with the highest rank.
This was implemented with a custom reduction operation
_mpi_array_lexicographic_min, which scaled poorly in parallel (probably due to MPI calling python code). Instead, we do separate MPI.MIN and and MPI.MAX allreduces which are much faster.