Bug: Latest code: Control panel - Geographic data

[ddrury]

All places are shown as available to delete.

I think MapDataServices->activePlaces() needs to be updated to reflect the changes introduced in Schema 45

And just out of interest why are we using the places table to get the active locations (and not the place_location table) because locations are not tied to a tree
As you were, I've just realised why

[arbor95]

I can't confirm. My places in Control panel - Geographic data show correct. But I possibly have another issue: see forum https://www.webtrees.net/index.php/forum/webtrees-help-and-support/40536-get-latitude-longitude-with-wt-2-2-5
I did my tests with 2.2.5. I do not know the last version when getting the coords was working ok.

[ddrury]

@arbor95 I'm reporting this based on the latest code i.e after the database schema is updated to 46.

[ddrury]

I think the query part of MapDataServices->activePlaces() needs changing to

        $rows = DB::table('places')
            ->join('gedcom', 'gedcom.gedcom_id', '=', 'p_file')
            ->join('gedcom_setting', 'gedcom_setting.gedcom_id', '=', 'gedcom.gedcom_id')
            ->whereIn('p_parent_id', $parents)
            ->select(['p_place', 'gedcom_name AS tree_name', 'gedcom.title AS tree_title', 'p_id'])

[ddrury]

Ignore the above query - it only works for a single tree, so as I'm not that good with queries it's over to you :)

[arbor95]

the latest test results imply that the server (provider) does not respond in time. but that has to be examined. this morning there was no problem on getting coords.