feat(combinators): Adds various basic combinators & impls for std types#34
Conversation
- Adds combinators for `fallback` and `map_value` - Adds implementations of `VariableMap` for slices, arrays, vectors, `Box`s, `Rc`s and `Arc`s - Fixes fizyr#20 See [example](examples/merge-environments.rs)
2e5e274 to
ad55676
Compare
|
Thanks for the PR! I think adding these is a nice improvement! I do think I want to re-organize the module layout a bit, to avoid having all these combinators in the crate root. But don't worry about that, I think it's easier to merge as is and then I can go over the module layout. I still need to do an in-depth review. Will keep you posted :) |
|
Yeah, I did notice that; it would be nice to have |
|
Yeah, no worries. I prefer to do that part myself anyway :) |
|
I did wonder about adding |
👍 I think a new struct is indeed more clear and easier to discover in the docs :) |
|
Thanks again! |
fallbackandmap_valueVariableMapfor slices, arrays, vectors,Boxs,Rcs andArcsexamples/merge-environments.rs