Merged
Conversation
Contributor
Author
|
@yocajii |
yocaji
reviewed
Aug 4, 2022
yocaji
left a comment
yocaji
left a comment
There was a problem hiding this comment.
@masanarih0ri
動作確認ばっちりでした。URLが環境で切り替わるようになっているんですね😳
1点だけコードについて質問させていただいたので、そちらだけご確認いただけますでしょうか🙇♂️
app/models/regular_event.rb
Outdated
| validate :end_at_be_greater_than_start_at | ||
| end | ||
|
|
||
| scope :holding, -> { where.not(finished: true) } |
There was a problem hiding this comment.
where(finished: false) でも良さそうに思えたのですが、これだと拾えないデータがあるとかでしょうか？
Contributor
Author
There was a problem hiding this comment.
どちらでも結果は同じだと思いますので、ご指摘いただいた内容に修正しました！
masanarih0ri
force-pushed
the
feature/add-discord-notify-for-tomorrow-regular-event
branch
from
53c5ab1 to
e27931c
Compare
Contributor
Author
|
@yocajii |
yocaji
approved these changes
Aug 6, 2022
yocaji
left a comment
yocaji
left a comment
There was a problem hiding this comment.
@masanarih0ri
ご対応くださいましてありがとうございます🙏✨
改めて動作とコードを確認して問題ないと思いましたのでApproveいたします🙆♂️
Contributor
Author
|
@yocajii @komagata |
komagata
deleted the
feature/add-discord-notify-for-tomorrow-regular-event
branch
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
issue
#4572
UI
確認方法
テスト観点