Merged
Conversation
Contributor
Author
|
@Seakimhour こちらのPRのレビューをおねがいします！ |
Seakimhour
approved these changes
Feb 7, 2023
Contributor
Seakimhour
left a comment
Seakimhour
left a comment
There was a problem hiding this comment.
@futa4095 レビュー依頼ありがとうございました。
確認をしましたー
問題ないので、Approveをさせていただきます！👍
Contributor
Author
|
@Seakimhour レビュー & Approveありがとうございます！！ |
Contributor
Author
|
@komagata チームメンバーからApproveいただきましたのでレビューおねがいします！ |
komagata
approved these changes
Feb 7, 2023
| admin: <%= ENV['DISCORD_ADMIN_WEBHOOK_URL'] || 'https://discord.com/api/webhooks/0123456789/admin' %> | ||
| mentor: <%= ENV['DISCORD_MENTOR_WEBHOOK_URL'] || 'https://discord.com/api/webhooks/0123456789/mentor' %> | ||
| all: <%= ENV['DISCORD_ALL_WEBHOOK_URL'] || 'https://discord.com/api/webhooks/0123456789/all' %> | ||
| introduction: <%= ENV['DISCORD_INTRODUCTION_WEBHOOK_URL'] || 'https://discord.com/api/webhooks/0123456789/introduction' %> |
komagata
deleted the
feature/post-first-report-submission-to-the-discord-introduction-channel
branch
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
概要
初日報の投稿をDiscordの自己紹介🥁チャンネルに通知するようにしました。
現在メンターのみに通知されていますが、Discord参加者全員が知ることができます。
変更確認方法
ローカル環境で動作確認を行う場合は自己紹介🥁チャンネルに通知を行うことはできないので、通知先を用意します。
また通知先のウェブフックURLを環境変数
DISCORD_INTRODUCTION_WEBHOOK_URLに設定しないと通知が行われません。feature/post-first-report-submission-to-the-discord-introduction-channelをローカルに取り込むDISCORD_INTRODUCTION_WEBHOOK_URL=<ウェブフックのURL> rails sでローカル環境を立ち上げますnippounashiでログインしますScreenshot
変更前
通知されません
変更後