Merged
Conversation
k-yano-gs
force-pushed
the
feature/add-youtube-link-to-footer
branch
2 times, most recently
from
efe3130 to
3398359
Compare
Contributor
Author
|
@harada-webdev |
ghost
reviewed
Mar 12, 2025
| = link_to 'https://roulette-talk.com/', class: 'footer-nav__item-link', target: '_blank', rel: 'noopener' do | ||
| | RouletteTalk | ||
| li.footer-nav__item | ||
| = link_to 'https://www.youtube.com/@%E3%83%95%E3%82%A3%E3%83%A8%E3%83%AB%E3%83%89%E3%83%96%E3%83%BC%E3%83%88%E3%82%AD%E3%83%A3%E3%83%B3%E3%83%97', class: 'footer-nav__item-link', target: '_blank', rel: 'noopener' do |
There was a problem hiding this comment.
https://www.youtube.com/@フィヨルドブートキャンプのように、日本語エンコードする前のリンクに変更したほうが可読性が上がると思います！
参考: #8308 (comment)
k-yano-gs
force-pushed
the
feature/add-youtube-link-to-footer
branch
from
3398359 to
bd7b1d2
Compare
Contributor
Author
|
@harada-webdev |
Contributor
Author
|
@harada-webdev @komagata |
Member
|
@kousei-ya conflictの解消をお願いします〜 |
k-yano-gs
force-pushed
the
feature/add-youtube-link-to-footer
branch
from
bd7b1d2 to
c05994f
Compare
Contributor
Author
|
@komagata |
Member
|
@kousei-ya 同じcommitが複数あるので正しい状態に修正してください。 
|
k-yano-gs
force-pushed
the
feature/add-youtube-link-to-footer
branch
from
471595f to
c05994f
Compare
k-yano-gs
force-pushed
the
feature/add-youtube-link-to-footer
branch
from
c05994f to
01227a8
Compare
Contributor
Author
|
@komagata |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
概要
変更確認方法
feature/add-youtube-link-to-footerをローカルに取り込むforeman start -f Procfile.devでサーバーを立ち上げるScreenshot
変更前
変更後