Conversation
Contributor
Author
|
@komagata さん |
komagata
reviewed
Apr 2, 2025
| @@ -8,7 +8,9 @@ class Article::SponsorshipsTest < ApplicationSystemTestCase | |||
| fill_in 'タイトル', with: 'sponsorshipページに表示される記事のタイトルです。' | |||
Member
There was a problem hiding this comment.
今回の変更とは別の行になりますが、Webからデータを入れるとDBに直接入れるのの1000倍は遅いと思うので修正したいです。特にこのテストはタイトルからすると表示の確認が目的で、データ追加は関係ないのでなおさらDBに直接入れたいです。
Contributor
Author
There was a problem hiding this comment.
@komagata さん
お疲れ様です
以前のWebからデータを追加する書き方ではなく、Article.create!()でデータを追加する書き方に修正いたしました。お手すきの際にレビューの確認をお願いいたします
lsesmpmido
force-pushed
the
bug/fix-sponsorships-test
branch
from
4413382 to
564068d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
sponsorships_test.rbの修正 #8512概要
#8346 で追加されたアラート機能に
sponsorships_test.rbのコードを対応させました
変更確認方法
bug/fix-sponsorships-testをローカルに取り込むgit fetch origin bug/fix-sponsorships-testgit switch bug/fix-sponsorships-testtest/system/article/sponsorships_test.rbのファイルを開くrails test test/system/article/sponsorships_test.rbを実行して自動テストが合格することを確認するScreenshot
変更前
変更後