-
Notifications
You must be signed in to change notification settings - Fork 75
入って1週間のユーザーにはメンターにしか表示されないマークを表示した #8700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
c6ca819
new-userかどうかを判定するjoining_statusメソッドを追加
hirokiej 44c89d0
動的にnew-userかstandard-userクラスを作成するjoining_status_classを追加
hirokiej 4d602f7
spanにユーザーのjoining_statusクラスを追加
hirokiej d6d6e56
Slimファイルにjoining_statusクラスを追加
hirokiej 4f07a06
joining_statusをフロントエンドでも利用できるようにした
hirokiej bdea2dc
ReactとVueファイルにjoining_statusを追加
hirokiej e9049b4
joining_statusに影響するクラスのテストを修正
hirokiej 79fb9e0
joiningStatusClass の修正に加え、類似のミスも修正
hirokiej 069cc67
APIユーザーのレスポンスのテストにjoining_statusを追加
hirokiej 22932ee
入って一週間未満のユーザーのアイコンの装飾を実装
machida cdf163f
spanを共通化した、user_role_status_spanメソッドを作成
hirokiej 09bcaf7
Slimファイルのspan部分をuser_role_status_spanに置き換えた
hirokiej 14edaf5
work_component.html.slimにアイコンを表示させるため、同様のメソッドを追加
hirokiej 7ec06d5
userのprimary_roleとjoining_statusをUserRoleStatusSpan.jsxで共通化
hirokiej eb2f260
UserRoleStatusSpan.jsxに共通化したためCommentUserIcon.jsxを削除
hirokiej d846f71
該当ファイルの処理をUserRoleStatusSpanに変更した
hirokiej 4db6ea4
User.jsxでUserRoleStatusSpanとgetUserRoleStatusClassを使用
hirokiej 7bee8c8
new-userでない場合、クラスを付与しないよう修正
hirokiej 274d088
keyを再レンダリング最適化のためaタグに移動
hirokiej 0bc2212
joining_statusで標準ユーザーにはクラスが付かないよう修正
hirokiej 7100978
user_role_status_spanメソッドをuser_icon_frame_classに変更
hirokiej 375960c
user_icon_frame_classをクラス名を返すだけに変更し、span生成を削除
hirokiej cf22f22
UserRoleStatusSpanをUserIconFrameClassに変更
hirokiej 0b94e30
UserIconFrameClassをクラス名のみ返すだけの関数に変更
hirokiej 935c081
ReactのUserRoleStatusSpanを UserIconFrameClassに書き換えた
hirokiej e71e47f
work_component.rbにUsersHelperをinclude
hirokiej 51f2e0c
Slimのuser_role_status_spanをuser_icon_frame_classに変更
hirokiej a2d1567
product_componentにUsersHelperをinclude
hirokiej bb33199
product_componentでuser_icon_frame_classに書き換え
hirokiej c409183
user_icon_frame_classのテスト作成
hirokiej d958508
Vueファイルでnew-userでない場合、空文字を返すようにした
hirokiej 52dcff2
user-icon.jsでnew-user以外はis-new-userクラスを付与しないように修正
hirokiej 3691f52
UsersHelperのuser_icon_frame_classをusers_decorator.rbに移動
hirokiej 5197fad
移動に伴いinclude UsersHelperを削除
hirokiej 833978b
user_decorator.rbに合わせてSlimファイルを修正
hirokiej 2fa81f6
user_icon_frame_classのテストをusers_helper_testからuser_decorator_testに移動
hirokiej 625d78a
テスト名を'#user_icon_frame_class'に修正
hirokiej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| export function UserIconFrameClass(user) { | ||
| return `a-user-role is-${user.primary_role} ${ | ||
| user.joining_status === 'new-user' ? 'is-new-user' : '' | ||
| }` | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| .a-user-icons__item | ||
| a.a-user-icons__item-link(href="#{user_path(started_or_submitted_student)}") | ||
| span.a-user-role(class="a-user-role is-#{started_or_submitted_student.primary_role}") | ||
| span class=started_or_submitted_student.user_icon_frame_class | ||
| = image_tag started_or_submitted_student.avatar_url, title: started_or_submitted_student.icon_title, class: 'a-user-icons__item-icon a-user-icon' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| li.user-icons__item | ||
| a.user-icons__item-link href=footprint.user.url | ||
| span.a-user-role class="is-#{footprint.user.primary_role}" | ||
| span class=footprint.user.user_icon_frame_class | ||
| img.a-user-icon.is-sm title=footprint.user.icon_title alt=footprint.user.icon_title src=footprint.user.avatar_url class="is-#{footprint.user.login_name}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.