Skip to content

ユーザーの提出物表示に関わる不要なvueファイルの削除#8814

Merged
komagata merged 2 commits intomainfrom
chore/user-products-vue-to-vanilla-js
Jul 5, 2025
Merged

ユーザーの提出物表示に関わる不要なvueファイルの削除#8814
komagata merged 2 commits intomainfrom
chore/user-products-vue-to-vanilla-js

Conversation

@kushimegu
Copy link
Copy Markdown
Contributor

@kushimegu kushimegu commented Jun 19, 2025

Issue

概要

提出物表示に関わっていた不要なVueファイルを削除した。

変更確認方法

  1. chore/user-products-vue-to-vanilla-jsをローカルに取り込む
  2. foreman start -f Procfile.devでサーバーを立ち上げる
  3. ログインする
  4. ユーザーの提出物詳細画面にアクセスし、提出物が表示されることを確認する

Screenshot

不要なファイル削除のため画面の変更はなし。

Summary by CodeRabbit

  • 削除
    • ユーザー提出物一覧の表示機能(UserProductsコンポーネント)が削除されました。
    • 個別の提出物カード表示機能(productコンポーネント)が削除されました。

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 19, 2025

"""

Walkthrough

user-products.vueproduct.vue の Vue コンポーネントが削除され、application.js からも UserProducts コンポーネントのインポートと登録が削除されました。これにより、ユーザー提出物の表示を担っていた Vue.js 実装がアプリケーションから完全に除去されました。

Changes

ファイル/グループ 変更内容概要
app/javascript/components/user-products.vue UserProducts Vue コンポーネントをファイルごと削除
app/javascript/product.vue product.vue Vue コンポーネントをファイルごと削除
app/javascript/packs/application.js UserProducts のインポートと VueMounter への登録を削除

Possibly related issues

  • user-products.vueを置き換える #8764: user-products.vue コンポーネントの削除と登録解除は、この issue の目的「Vue コンポーネントを Rails ビュー+バニラ JS 実装に置き換える」と一致しています。

Poem

🐇
サヨナラ、Vue の提出物、
春風にのって消えていく。
新しい景色、Rails の光、
みんなのコードがまた一歩進む。
うさぎも跳ねる、軽やかな朝、
新しい始まり、ここにある!

"""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f18f7dc and 32f29d9.

📒 Files selected for processing (3)
  • app/javascript/components/user-products.vue (0 hunks)
  • app/javascript/packs/application.js (0 hunks)
  • app/javascript/product.vue (0 hunks)
💤 Files with no reviewable changes (3)
  • app/javascript/packs/application.js
  • app/javascript/product.vue
  • app/javascript/components/user-products.vue
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build_and_test
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kushimegu kushimegu marked this pull request as ready for review June 19, 2025 07:03
@kushimegu kushimegu self-assigned this Jun 20, 2025
@kushimegu kushimegu requested a review from e-yanagita-gs June 20, 2025 04:37
@kushimegu
Copy link
Copy Markdown
Contributor Author

@e-yanagita-gs
お疲れ様です!
こちらのレビューをお願いできませんか?

Copy link
Copy Markdown
Contributor

@e-yanagita-gs e-yanagita-gs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushimegu
お疲れ様です!
1点気になる点がありましたのでコメントしています。
ご確認よろしくお願いいたしますm(_ _)m

| 提出物はまだありません。
</template>
<script>
import Product from '../product.vue'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここでimportされているproduct.vueですが、今回の修正で不要になったように見受けられます。
※試してみたところ、product.vueを削除しても正常に提出物が表示されました。
今回のIssueの要件にproduct.vueの削除が含まれていないので要確認ですが、削除してもいいかもしれません...

@kushimegu kushimegu force-pushed the chore/user-products-vue-to-vanilla-js branch from f18f7dc to 32f29d9 Compare June 27, 2025 06:40
@e-yanagita-gs
Copy link
Copy Markdown
Contributor

@kushimegu
お疲れ様です!
こちらは再レビューしてもよろしいでしょうか?
よろしければ、Re-request reviewの設定をお願いいたします🙇‍♀️

@kushimegu kushimegu requested a review from e-yanagita-gs June 30, 2025 05:01
@kushimegu
Copy link
Copy Markdown
Contributor Author

@e-yanagita-gs
お疲れ様です!
requestしましたのでお願いいたします

Copy link
Copy Markdown
Contributor

@e-yanagita-gs e-yanagita-gs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認させていただきました!
特に不具合はありませんでしたので、Approveいたします。
お疲れ様でした🙇‍♀️

@kushimegu
Copy link
Copy Markdown
Contributor Author

@e-yanagita-gs
レビューありがとうございました!

@komagata
メンバーレビューが終わりましたのでこちらの確認をお願いいたします

Copy link
Copy Markdown
Member

@komagata komagata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認させて頂きました。OKです〜🙆‍♂️

@komagata komagata merged commit ea76667 into main Jul 5, 2025
8 checks passed
@komagata komagata deleted the chore/user-products-vue-to-vanilla-js branch July 5, 2025 09:28
@github-actions github-actions bot mentioned this pull request Jul 5, 2025
87 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants