-
Notifications
You must be signed in to change notification settings - Fork 75
speakブロックに引数を渡し、アバターと名前を表示 #8932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3089ed8
speak blockに引数で名前とアバター画像を指定する機能を追加
su-su-su-su 2755730
@を使わない新しい記法にはリンクが出ないようにした
su-su-su-su 5c5079c
aタグがないと名前が開業する為、暫定的にaタグを使用
su-su-su-su c92c17e
speakerNameをURLエンコードする
su-su-su-su 2f11ba0
avatarUrlをエスケープしてXSS脆弱性を修正
su-su-su-su dc7a2a4
文字列置換ロジックの脆弱性を改善
su-su-su-su d584e99
peakブロックの引数バリデーションを強化
su-su-su-su 63146f7
a-user-emoji-linkがspanでもデザイン崩れがないようにした
machida d4ae362
Sassのセレクタ指定を修正
su-su-su-su a5709b6
リンクが不要な記法をaタグからspanタグに変更
su-su-su-su b18c09a
speak blockの正規表現で改行を許容
su-su-su-su dce47b1
非会員speak blockの@表示を削除
su-su-su-su 7c5b0dc
テストを追加
su-su-su-su e36cfc7
schema.rbを更新
su-su-su-su f32007d
schema.rbを元のコードに復元
su-su-su-su e994314
条件分岐を整理してネストを削減
su-su-su-su File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if の条件分岐が少し多めに見えました👀
ネストも少し深くなっているので、どのパターンでどういう処理が走るのかを把握するのに少し時間がかかるかも?と感じました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご指摘ありがとうございます!
確かに条件分岐が多く、ネストも深くて理解しにくい状態でした。
早期リターンパターンでリファクタリングし、処理パターンが分かりやすいように修正いたしました。