-
Notifications
You must be signed in to change notification settings - Fork 75
Product系3クラス分newspaperをActiveSupport::Notificationsに移行 #8965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
komagata
merged 6 commits into
main
from
chore/replace-newspaper-with-notifications-in-product-notifier
Jul 24, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3b12059
ProductAuthorWatcherをNewspaperからActiveSupport::Notificationsへ移行
hirokiej 1e15948
ProductNotifierForColleagueをNewspaperからActiveSupport::Notificationsへ移行
hirokiej 5b0ea11
ProductNotifierForPracticeWatcherをNewspaperからActiveSupport::Notificat…
hirokiej 4b1f6ba
3クラス分の移行が完了したため、不要なNewspaper.publish(:product_create)を削除
hirokiej 394863c
提出物作成時に投稿者のWatchが重複しないよう修正
hirokiej 5037d78
テストコードを修正
hirokiej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| class ProductAuthorWatcher | ||
| def call(payload) | ||
| def call(_name, _started, _finished, _unique_id, payload) | ||
| product = payload[:product] | ||
| Watch.create!(user: product.user, watchable: product) | ||
| Watch.find_or_create_by!(user: product.user, watchable: product) | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,8 +23,15 @@ class ProductNotifierForPracticeWatcherTest < ActiveSupport::TestCase | |
| ) | ||
| product.save! | ||
|
|
||
| payload = { product: } | ||
| perform_enqueued_jobs do | ||
| ProductNotifierForPracticeWatcher.new.call({ product: }) | ||
| ProductNotifierForPracticeWatcher.new.call( | ||
| 'product_create', | ||
| Time.current, | ||
| Time.current, | ||
| 'unique_id', | ||
| payload | ||
| ) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 使わない引数でも、nilを使わずにラベリングすると可読性が高くなりますね!💡 |
||
| end | ||
| assert Notification.where(user_id: watch.user_id, sender_id: product.user_id, | ||
| message: "#{product.user.login_name}さんが「#{product.practice.title}」の提出物を提出しました。").exists? | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
カスタムクエリで安全性が高まっていいなと思いました👍