Skip to content

不要なクラスを削除#9016

Merged
machida merged 1 commit intomainfrom
fix-kadomaru
Aug 20, 2025
Merged

不要なクラスを削除#9016
machida merged 1 commit intomainfrom
fix-kadomaru

Conversation

@machida
Copy link
Copy Markdown
Member

@machida machida commented Aug 5, 2025

Summary by CodeRabbit

  • スタイル
    • ユーザー一覧の各アイテム外側ラッパーから個別カスタム枠を削除し、全体表示がより統一されます。
    • アバター周りの枠は引き続き適用されるため、アイコン周辺の見た目は維持されます。
    • 結果としてリストの視覚的一貫性が向上し、表示の乱れが減少します。

@machida machida self-assigned this Aug 5, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Aug 5, 2025

Walkthrough

User.jsx の外側ラッパー div から、ユーザーごとに動的に付与されていた CSS クラス UserIconFrameClass(user) を削除し、静的なクラス "users-item__inner a-card" のみを適用するよう変更されました。その他のマークアップやロジックは変更なし(アバターフレームのクラス適用は維持)。

Changes

Cohort / File(s) Change Summary
User アイコンフレームクラス削除
app/javascript/components/User.jsx
外側 wrapper の className から UserIconFrameClass(user) 呼び出しを削除し、静的クラス "users-item__inner a-card" のみを使用するよう修正。アバターフレーム(span)や画像側の使用は変更なし。

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

ぼくはうさぎ、コードの庭でぴょん、
余計なクラスをそっとはずしたよ。
カードはすっきり、動きはそのまま、
アバターは微笑み、風にゆれて、
今日も軽やか、バグ無き道へ。 🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8d5d9fb and 60e5594.

📒 Files selected for processing (1)
  • app/javascript/components/User.jsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/javascript/components/User.jsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build_and_test
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-kadomaru

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot requested a review from komagata August 5, 2025 16:14
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
app/javascript/components/User.jsx (1)

28-28: 不要なテンプレートリテラルを通常の文字列リテラルに置換しませんか?

式展開がないためバッククォートは冗長です。シンプルな文字列にすると可読性が向上します。

-        <div className={`users-item__inner a-card`}>
+        <div className="users-item__inner a-card">
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 78e2130 and 5906c56.

📒 Files selected for processing (1)
  • app/javascript/components/User.jsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build_and_test

@machida machida merged commit bc2b777 into main Aug 20, 2025
3 checks passed
@machida machida deleted the fix-kadomaru branch August 20, 2025 07:03
@github-actions github-actions bot mentioned this pull request Aug 20, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant