Skip to content

ダッシュボードのブックマーク表示機能をReactからViewComponentに移行#9205

Draft
matuaya wants to merge 1 commit intomainfrom
chore/replace-react-with-viewcomponent-for-dashboard-bookmarks
Draft

ダッシュボードのブックマーク表示機能をReactからViewComponentに移行#9205
matuaya wants to merge 1 commit intomainfrom
chore/replace-react-with-viewcomponent-for-dashboard-bookmarks

Conversation

@matuaya
Copy link
Copy Markdown
Contributor

@matuaya matuaya commented Sep 24, 2025

Issue

- BookmarksInDashboard.jsxを非React化する #9045

概要

ダッシュボードのブックマーク表示機能をReactからViewComponentに移行しました。

変更確認方法

  1. chore/replace-react-with-viewcomponent-for-dashboard-bookmarksをローカルに取り込む

Screenshot

変更前

変更後

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 24, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/replace-react-with-viewcomponent-for-dashboard-bookmarks

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tyrrell-IH
Copy link
Copy Markdown
Contributor

@matuaya
急に話しかけてすいません🙏
本PRの実装について相談したいことがあります。

ブックマークのラベル部分について、現状の実装だと「定期イベント」などの長いモデル名が上手く折り返しができないと思うので、その部分を対応していただきたいな〜という話です。

つまり現状の実装では
↓こうなってしまうのを
image

↓この状態にしてほしいです。
image

以下が参考のPRです
定期イベントにブックマークボタンを追加

具体的には

- else
.card-list-item__label
= type.human

type.humanのところを私の方のPRで作成したLabelHelperを使ってbookmarkable_label(type)みたいにしていただければ上手く折り返しができるのではないかと思います。

ご検討の程をお願いします!
また何かわからないことがあればご質問ください〜

@matuaya
Copy link
Copy Markdown
Contributor Author

matuaya commented Jan 29, 2026

@tyrrell-IH
ご提案ありがとうございます!了解しました👍
今はこのissueの作業を中断中なのですが、再開次第対応したいと思います。

@tyrrell-IH
Copy link
Copy Markdown
Contributor

@matuaya
承知しました!
よろしくお願いします🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants