Skip to content

Cloud Build: TerminateConnectionsにAPP_HOST_NAMEを追加#9352

Merged
komagata merged 1 commit intomainfrom
fix/cloudbuild-add-app-host-name
Dec 10, 2025
Merged

Cloud Build: TerminateConnectionsにAPP_HOST_NAMEを追加#9352
komagata merged 1 commit intomainfrom
fix/cloudbuild-add-app-host-name

Conversation

@komagata
Copy link
Copy Markdown
Member

@komagata komagata commented Dec 10, 2025

Summary

  • production.rbでAPP_HOST_NAMEが必須になっているため、TerminateConnectionsステップでRailsが起動できなかった
  • TerminateConnectionsステップにAPP_HOST_NAME=$_APP_HOST_NAMEを追加

Test plan

  • マージ後にCloud Buildを実行してデプロイが成功することを確認

🤖 Generated with Claude Code

Summary by CodeRabbit

リリースノート

  • Chores
    • ステージング環境のデプロイメント設定を更新しました。

✏️ Tip: You can customize this high-level summary in your review settings.

production.rbでAPP_HOST_NAMEが必須になっているため、
TerminateConnectionsステップでRailsが起動できなかった。

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Cloud Build の設定ファイルにおいて、TerminateConnections ステップと Deploy ステップの環境変数に APP_HOST_NAME を追加しました。

Changes

Cohort / File(s) Summary
Cloud Build 設定の環境変数追加
.cloudbuild/cloudbuild-staging.yaml
TerminateConnections ステップと Deploy ステップ(set-env-vars)の環境変数に APP_HOST_NAME を追加

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

雑事

Poem

🐰 ホスト名を環境へ添えて
ステップたちが笑顔に
デプロイの道、つながりて
クラウドの空へ舞い上がる ☁️

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/cloudbuild-add-app-host-name

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c1d7648 and b0a90a7.

📒 Files selected for processing (1)
  • .cloudbuild/cloudbuild-staging.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant