Conversation
📝 WalkthroughWalkthroughリアクションのドロップダウン幅と位置指定を変更、ドロップダウン親の Changes
Sequence Diagram(s)（該当なし） Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@app/assets/stylesheets/shared/blocks/card-list/_card-list-item.css`:
- Around line 182-184: The WIP state (.card-list-item.is-wip) can be overridden
by the existing title hover rule that sets .card-list-item-title__title to
var(--main); add a more specific hover rule targeting the WIP link to preserve
the muted color on hover, e.g. a selector using .card-list-item.is-wip
.card-list-item-title__link:hover and set color: var(--muted-text) so WIP items
stay gray even when hovered.
🧹 Nitpick comments (1)
app/assets/stylesheets/application/blocks/reaction/_reaction.css (1)
25-30:calc(100% - -8px)は可読性が低いので+ 8px表記へ意図は明確ですが、二重否定は読みづらいので
calc(100% + 8px)へ置き換えると保守性が上がります。🧹 変更案
- top: calc(100% - -8px); + top: calc(100% + 8px);
Comment on lines
+182
to
+184
| .card-list-item.is-wip .card-list-item-title__link { | ||
| color: var(--muted-text); | ||
| } |
There was a problem hiding this comment.
WIP時のホバー色が上書きされる可能性
既存のホバー規則（Line 69-72）が .card-list-item-title__title を var(--main) にするため、WIPでもホバー時に青へ戻る可能性があります。WIPは常時グレー表示が要件なら、ホバー時の上書きルールを追加してください。
💡 追加ルール案
.card-list-item.is-wip .card-list-item-title__link {
color: var(--muted-text);
}
+.card-list-item.is-wip a.card-list-item__inner:hover .card-list-item-title__title,
+.card-list-item.is-wip a.card-list-item__inner:hover .card-list-item-title__link {
+ color: var(--muted-text);
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| .card-list-item.is-wip .card-list-item-title__link { | |
| color: var(--muted-text); | |
| } | |
| .card-list-item.is-wip .card-list-item-title__link { | |
| color: var(--muted-text); | |
| } | |
| .card-list-item.is-wip a.card-list-item__inner:hover .card-list-item-title__title, | |
| .card-list-item.is-wip a.card-list-item__inner:hover .card-list-item-title__link { | |
| color: var(--muted-text); | |
| } |
🤖 Prompt for AI Agents
In `@app/assets/stylesheets/shared/blocks/card-list/_card-list-item.css` around
lines 182 - 184, The WIP state (.card-list-item.is-wip) can be overridden by the
existing title hover rule that sets .card-list-item-title__title to var(--main);
add a more specific hover rule targeting the WIP link to preserve the muted
color on hover, e.g. a selector using .card-list-item.is-wip
.card-list-item-title__link:hover and set color: var(--muted-text) so WIP items
stay gray even when hovered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9604
Summary by CodeRabbit
リリースノート